Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint perf improvement #10775

Merged
merged 1 commit into from
Mar 31, 2021
Merged

eslint perf improvement #10775

merged 1 commit into from
Mar 31, 2021

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Mar 30, 2021 •
edited
Loading

Develop: 154.76s total. 31.1 seconds for prettier, 11.42 seconds for import/namespace, 48.82 seconds for the top mocha rules?

➜ TIMING=1 yarn eslint . --ext js
yarn run v1.22.4
$ /Users/braddecker/Dev/consensys/metamask-extension/node_modules/.bin/eslint . --ext js
Rule                           | Time (ms) | Relative
:------------------------------|----------:|--------:
prettier/prettier              | 31408.751 |    24.1%
import/namespace               | 11417.413 |     8.8%
mocha/no-nested-tests          | 10285.072 |     7.9%
mocha/no-identical-title       |  8847.269 |     6.8%
mocha/no-skipped-tests         |  6528.291 |     5.0%
mocha/no-exclusive-tests       |  6485.040 |     5.0%
mocha/no-hooks-for-single-case |  6025.373 |     4.6%
mocha/max-top-level-suites     |  3739.456 |     2.9%
mocha/no-async-describe        |  3454.342 |     2.7%
mocha/no-global-tests          |  3441.664 |     2.6%
✨  Done in 154.76s.

This PR:
Develop: 93.55s total. 11.36 seconds for prettier, 11.39 seconds for import/namespace, 17.18 seconds for the top mocha rules

➜ TIMING=1 yarn eslint . --ext js
yarn run v1.22.4
$ /Users/braddecker/Dev/consensys/metamask-extension/node_modules/.bin/eslint . --ext js
Rule                           | Time (ms) | Relative
:------------------------------|----------:|--------:
import/namespace               | 11392.980 |    16.2%
prettier/prettier              | 11359.871 |    16.1%
mocha/no-nested-tests          |  4515.200 |     6.4%
mocha/no-identical-title       |  4025.436 |     5.7%
mocha/no-hooks-for-single-case |  2907.527 |     4.1%
mocha/no-exclusive-tests       |  2868.671 |     4.1%
mocha/no-skipped-tests         |  2854.651 |     4.0%
node/no-extraneous-import      |  2708.008 |     3.8%
node/no-restricted-import      |  2447.184 |     3.5%
import/named                   |  1739.707 |     2.5%
✨  Done in 93.55s.

@metamaskbot
Copy link
Collaborator

Builds ready [461fc3e]
Page Load Metrics (558 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44735484
domContentLoaded3777715579646
load3787725589646
domInteractive3767715569646

@metamaskbot
Copy link
Collaborator

Builds ready [8b51f79]
Page Load Metrics (507 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44695484
domContentLoaded34261550510048
load34461650710048
domInteractive34261450510048

@brad-decker brad-decker marked this pull request as ready for review March 30, 2021 20:36
@brad-decker brad-decker requested a review from a team as a code owner March 30, 2021 20:36
@brad-decker brad-decker requested a review from danjm March 30, 2021 20:36
@brad-decker brad-decker changed the title WIP eslint perf improvement eslint perf improvement Mar 30, 2021
rekmarks
rekmarks approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should play well with our updated config, which includes a lot of these changes.

@brad-decker brad-decker merged commit d5bfce3 into develop Mar 31, 2021
@brad-decker brad-decker deleted the upgrade-prettier branch March 31, 2021 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brad-decker @metamaskbot @rekmarks